PMM-14170: Add Valkey setup and configuration scripts #154
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
travagliad
requested review from
yurkovychv,
puneet0191,
olexandr-havryliak and
sandraromanchenko
as code owners
|
|
||
| - name: Display generated Valkey password | ||
| debug: | ||
| msg: "Generated Valkey password: {{ valkey_password }}" |
There was a problem hiding this comment.
It would be better to have one password not to generate one, because then our tests would not have a way to know the correct password.
|
|
||
| - name: Add the primary to monitoring | ||
| community.docker.docker_container_exec: | ||
| container: "{{ pmm_server_name }}" |
There was a problem hiding this comment.
PMM client should be installed inside of valkey container please check setup for Percona server version 8.4
| container: "{{ pmm_server_name }}" | ||
| command: pmm-admin add valkey --cluster=valkey-cluster --environment=valkey-test --username=default --password="{{ valkey_password }}" --service-name=sentinel{{ item }}-svc --host=sentinel-{{ item }} --port={{ sentinel_start_port }} --custom-labels='role=sentinel' | ||
| loop: "{{ range(1, sentinel_count + 1) | list }}" | ||
| ignore_errors: yes |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Introduce scripts and configuration files for setting up Valkey, including primary, replica, and sentinel configurations, along with a cleanup script and integration into the existing setup framework.